Stream: git-wasmtime

Topic: wasmtime / PR #4720 Enable back-edge CFI by default on macOS

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 14:18):

akirilov-arm opened PR #4720 from pauth to main:

This PR is a follow-up to #3606. One fiber test is still using the system unwinder implementation, so I have disabled it conservatively.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 14:18):

akirilov-arm requested cfallin for a review on PR #4720.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 14:18):

akirilov-arm requested bnjbvr for a review on PR #4720.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 19:38):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 19:38):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 19:38):

cfallin created PR review comment:

Likewise here, the instruction doesn't need any operands from RA's point of view I think.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 16 2022 at 19:38):

cfallin created PR review comment:

This use of SP and the mod/use of LR below shouldn't be necessary, as the registers are not allocatable so the RA doesn't need to track liveranges over them. I think this match arm can work the same as the Ret case above, unless I'm missing some new constraint!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 17 2022 at 17:52):

akirilov-arm updated PR #4720 from pauth to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 17 2022 at 20:06):

alexcrichton merged PR #4720.

Last updated: Oct 23 2024 at 20:03 UTC