Stream: git-wasmtime

Topic: wasmtime / PR #4709 x64: Compare source arguments in prod...

Wasmtime GitHub notifications bot (Aug 15 2022 at 17:49):

elliottt opened PR #4709 from trevor/produces-const-bug to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 15 2022 at 17:57):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 15 2022 at 18:00):

elliottt edited PR #4709 from trevor/produces-const-bug to main:

This PR changes the behavior of produces_const in the x64 backend to check that the two source registers are the same, rather than check that the second source and destination are the same. The reason for this change is a mismatch in behavior between the ISLE constructors for those pseudo instructions and the existing rust functions for constructing them: the rust functions always ensure that the first source and destination registers are the same, while the isle functions introduce a fresh destination register and take the two sources as arguments.

This change preserves the existing behavior for instructions constructed through the rust functions, but allows the lower.isle to use instructions like (x64_xor x x) where x is a fresh register without causing a panic in RA2.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 15 2022 at 18:01):

elliottt has marked PR #4709 as ready for review.

Wasmtime GitHub notifications bot (Aug 15 2022 at 18:51):

elliottt has enabled auto merge for PR #4709.

Wasmtime GitHub notifications bot (Aug 15 2022 at 19:00):

elliottt merged PR #4709.

Last updated: Dec 23 2024 at 12:05 UTC