Wasmtime GitHub notifications bot (Aug 15 2022 at 17:14): Wasmtime GitHub notifications bot (Aug 15 2022 at 17:14):alexcrichton opened PR #4708 from less-recursion to main:
It appears that given any amount of recursion in Wasmtime based on the type structure of a component the fuzzers will find a stack overflow. To that end this commit fixes an issue that the fuzzers have found where calculating the flat type representation was overflowing the stack due to the recursive nature of the implementation.
The fix here additionally improves upon the previous implementation by caching flat type information per-type instead of recomputing it each time it's queried. This means there's no special need to handle recursion one way or another here and it also greatly improves performance, especially for the
fact-valid-modulefuzzer.
Wasmtime GitHub notifications bot (Aug 15 2022 at 17:14):alexcrichton requested fitzgen for a review on PR #4708.
Wasmtime GitHub notifications bot (Aug 15 2022 at 17:29):alexcrichton updated PR #4708 from less-recursion to main.
Wasmtime GitHub notifications bot (Aug 15 2022 at 18:52):alexcrichton updated PR #4708 from less-recursion to main.
Wasmtime GitHub notifications bot (Aug 16 2022 at 17:51):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 16 2022 at 18:31):alexcrichton merged PR #4708.
Last updated: Oct 23 2024 at 20:03 UTC