Stream: git-wasmtime

Topic: wasmtime / PR #4706 cranelift: Fix `icmp.i128 eq` for aar...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2022 at 10:15):

afonso360 opened PR #4706 from aarch64-i128-eq to main:

:wave: Hey,

This fixes #4705. I mostly just copied what LLVM is doing (see: https://godbolt.org/z/GbvErThK1)

cc: @akirilov-arm
cc: https://github.com/bjorn3/rustc_codegen_cranelift/issues/1256

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2022 at 10:34):

afonso360 updated PR #4706 from aarch64-i128-eq to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2022 at 10:53):

afonso360 updated PR #4706 from aarch64-i128-eq to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 13:38):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 13:38):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 13:38):

akirilov-arm created PR review comment:

Unless I am missing something, this looks too complicated - contrast with:

cmp lhs_lo, rhs_lo
ccmp lhs_hi, rhs_hi, #0, eq
cset dst, {eq, ne}

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 14:44):

afonso360 created PR review comment:

That does look correct, and much shorter! Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 14:44):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 14:54):

afonso360 updated PR #4706 from aarch64-i128-eq to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 18:11):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2022 at 18:11):

cfallin merged PR #4706.

Last updated: Nov 22 2024 at 17:03 UTC