Stream: git-wasmtime

Topic: wasmtime / PR #4691 Don't be clever about representing no...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 17:27):

alexcrichton opened PR #4691 from fix-build to main:

This commit fixes a build warning on Rust 1.63 when the memory-init-cow
feature is disabled in the wasmtime-runtime crate. Some "tricks" were
used prior to have the MemoryImage type be an empty enum {} but that
wreaks havoc with warnings so this commit instead just makes it a unit
struct and makes all methods panic (as they shouldn't be hit anyway).

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 17:29):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 17:55):

jameysharp has enabled auto merge for PR #4691.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 18:16):

jameysharp merged PR #4691.


Last updated: Dec 23 2024 at 12:05 UTC