Stream: git-wasmtime

Topic: wasmtime / PR #4691 Don't be clever about representing no...

Wasmtime GitHub notifications bot (Aug 11 2022 at 17:27):

alexcrichton opened PR #4691 from fix-build to main:

This commit fixes a build warning on Rust 1.63 when the memory-init-cow
feature is disabled in the wasmtime-runtime crate. Some "tricks" were
used prior to have the MemoryImage type be an empty enum {} but that
wreaks havoc with warnings so this commit instead just makes it a unit
struct and makes all methods panic (as they shouldn't be hit anyway).

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 11 2022 at 17:29):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 11 2022 at 17:55):

jameysharp has enabled auto merge for PR #4691.

Wasmtime GitHub notifications bot (Aug 11 2022 at 18:16):

jameysharp merged PR #4691.

Last updated: Nov 22 2024 at 17:03 UTC