alexcrichton opened PR #4691 from fix-build
to main
:
This commit fixes a build warning on Rust 1.63 when the
memory-init-cow
feature is disabled in thewasmtime-runtime
crate. Some "tricks" were
used prior to have theMemoryImage
type be an emptyenum {}
but that
wreaks havoc with warnings so this commit instead just makes it a unit
struct and makes all methods panic (as they shouldn't be hit anyway).<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
cfallin submitted PR review.
jameysharp has enabled auto merge for PR #4691.
jameysharp merged PR #4691.
Last updated: Dec 23 2024 at 12:05 UTC