Wasmtime GitHub notifications bot (Aug 11 2022 at 00:50): Wasmtime GitHub notifications bot (Aug 11 2022 at 00:50):elliottt opened PR #4685 from trevor/isle-and-pattern-bug to main:
- Add a test case that exposes the bug
- Add a custom ord instance for PatternInst
- Revert "Add a custom ord instance for PatternInst"
- Fixup test case
- Order fallible extractors first
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 11 2022 at 00:50):elliottt updated PR #4685 from trevor/isle-and-pattern-bug to main.
Wasmtime GitHub notifications bot (Aug 11 2022 at 01:00):elliottt edited PR #4685 from trevor/isle-and-pattern-bug to main:
Fix a bug with extractor ordering, where constant patterns were taking precedence over fallible extractors.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 11 2022 at 01:05):elliottt edited PR #4685 from trevor/isle-and-pattern-bug to main:
Fix a bug with extractor ordering, where constant patterns were taking precedence over fallible extractors.
I started by writing a custom
Ordinstance but it felt like the rules for how fallible/infallible constructors related to everything else would get a bit hard to reason about. @cfallin suggested breaking theExtractorcase into to constructors, which ended up being much more readable.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 11 2022 at 01:06):elliottt edited PR #4685 from trevor/isle-and-pattern-bug to main:
Fix a bug with extractor ordering, where constant patterns were taking precedence over fallible extractors.
I started by writing a custom
Ordinstance but it felt like the rules for how fallible/infallible constructors related to everything else would get a bit hard to reason about. @cfallin suggested breaking theExtractorcase into to constructors, which ended up being much more readable.This PR does change the output of some of the filetest tests, which suggests that we might have been masking some more specific branches during lowering.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 11 2022 at 01:07):elliottt updated PR #4685 from trevor/isle-and-pattern-bug to main.
Wasmtime GitHub notifications bot (Aug 11 2022 at 01:08):elliottt has marked PR #4685 as ready for review.
Wasmtime GitHub notifications bot (Aug 11 2022 at 03:55):elliottt edited PR #4685 from trevor/isle-and-pattern-bug to main:
Fix a bug with extractor ordering, where constant patterns were taking precedence over fallible extractors.
I started by writing a custom
Ordinstance but it felt like the rules for how fallible/infallible constructors related to everything else would get a bit hard to reason about. @cfallin suggested breaking theExtractorcase into to constructors, which ended up being much more readable.This PR does change the output of some of the filetest tests, which suggests that we might have been masking some more specific branches during lowering. I'll need to have a look through the precise-output tests that changed to check if this is the right way to fix the interaction between fallible extractors and constants.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 11 2022 at 19:55):elliottt closed without merge PR #4685.
Last updated: Dec 23 2024 at 13:07 UTC