Stream: git-wasmtime

Topic: wasmtime / PR #4684 x64: Lower fcvt_from_uint in ISLE

Wasmtime GitHub notifications bot (Aug 10 2022 at 22:27):

elliottt opened PR #4684 from trevor/x64-fcvt-from-uint to main:

• Add a test for the existing behavior of fcvt_from_unit
• Migrate the I8, I16, I32 cases of fcvt_from_uint
• Implement the I64 case of fcvt_from_uint
• Add a test for the existing behavior of fcvt_from_uint.f64x2
• Migrate fcvt_from_uint.f64x2 to ISLE
• Lower the last case of fcvt_from_uint
• Add a test for fcvt_from_uint
• Finish lowering fcmp_from_uint

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 10 2022 at 22:30):

elliottt edited PR #4684 from trevor/x64-fcvt-from-uint to main:

Lower fcvt_from_uint in ISLE, instead of rust.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 11 2022 at 01:08):

elliottt updated PR #4684 from trevor/x64-fcvt-from-uint to main.

Wasmtime GitHub notifications bot (Aug 11 2022 at 03:54):

elliottt has marked PR #4684 as ready for review.

Wasmtime GitHub notifications bot (Aug 11 2022 at 19:28):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 11 2022 at 19:28):

cfallin merged PR #4684.

Last updated: Dec 23 2024 at 12:05 UTC