Stream: git-wasmtime

Topic: wasmtime / PR #4679 List preset's settings in generated c...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 18:41):

jameysharp requested cfallin for a review on PR #4679.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 18:41):

jameysharp opened PR #4679 from show-settings-presets to main:

Figuring out which boolean settings go into each preset is not easy by
inspecting the DSL source (e.g. meta/src/isa/x86.rs). This patch extends
the comments in the Rust that's generated by that DSL to list the names
of the settings together with the name of the preset.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 18:41):

jameysharp requested elliottt for a review on PR #4679.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 19:03):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 19:06):

jameysharp has enabled auto merge for PR #4679.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 19:56):

jameysharp merged PR #4679.

Last updated: Dec 23 2024 at 12:05 UTC