Stream: git-wasmtime

Topic: wasmtime / PR #4672 [fuzz] Fix order of operands passed i...

Wasmtime GitHub notifications bot (Aug 10 2022 at 13:41):

abrown opened PR #4672 from fix-4671 to main:

In #4671, the meta-differential fuzz target was finding errors when
running certain Wasm modules (specifically shr_s in that case).
@conrad-watt diagnosed the issue as a missing reversal in the operands
passed to the spec interpreter. This change fixes #4671 and adds an
additional unit test to keep it fixed.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 10 2022 at 13:43):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Aug 10 2022 at 13:43):

bjorn3 created PR review comment:

Is this a bug in the official wasm interpreter?

Last updated: Nov 22 2024 at 16:03 UTC