Stream: git-wasmtime

Topic: wasmtime / PR #4672 [fuzz] Fix order of arguments passed ...

Wasmtime GitHub notifications bot (Aug 10 2022 at 13:43):

abrown edited PR #4672 from fix-4671 to main:

In #4671, the meta-differential fuzz target was finding errors when
running certain Wasm modules (specifically shr_s in that case).
@conrad-watt diagnosed the issue as a missing reversal in the operands
passed to the spec interpreter. This change fixes #4671 and adds an
additional unit test to keep it fixed.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 10 2022 at 13:49):

conrad-watt created PR review comment:

Internally, the interpreter represents the value stack as a list in reverse order, so that popping from the stack is equivalent to taking the head of the list.

My tweaked version of the interpreter exposes an entrypoint function that assumes this reversal has already happened, hence the confusion. When I cut a new version of my interpreter, I can investigate if it makes sense to push the reversal down further, but an advantage of doing it this way is that the rev and map operations can be carried out simultaneously, which is more efficient.

Wasmtime GitHub notifications bot (Aug 10 2022 at 13:49):

conrad-watt submitted PR review.

Wasmtime GitHub notifications bot (Aug 10 2022 at 13:50):

conrad-watt edited PR review comment.

Wasmtime GitHub notifications bot (Aug 10 2022 at 14:23):

conrad-watt submitted PR review.

Wasmtime GitHub notifications bot (Aug 10 2022 at 14:24):

conrad-watt submitted PR review.

Wasmtime GitHub notifications bot (Aug 10 2022 at 14:55):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 10 2022 at 14:55):

alexcrichton merged PR #4672.

Last updated: Nov 22 2024 at 16:03 UTC