Stream: git-wasmtime

Topic: wasmtime / PR #4670 cranelift: Upgrade libm to 0.2.4

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 09:01):

afonso360 opened PR #4670 from update-libm to main:

This resolves an issue with incorrect fmaf on the x86_64-pc-windows-gnu target under some inputs.

See: #4517

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 09:04):

afonso360 edited PR #4670 from update-libm to main:

This resolves an issue with incorrect fmaf on the x86_64-pc-windows-gnu target under some inputs.

This was fixed in https://github.com/rust-lang/libm/pull/267

See: #4517

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 09:31):

bjorn3 created PR review comment:

Can you also check it with fma instructions?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 09:31):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 09:32):

bjorn3 edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 09:42):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 09:42):

afonso360 created PR review comment:

Yes! As soon as https://github.com/bytecodealliance/wasmtime/pull/4539 is merged.

Although that needs a rebase.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 14:54):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 15:02):

afonso360 updated PR #4670 from update-libm to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 15:03):

alexcrichton has enabled auto merge for PR #4670.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 16:08):

alexcrichton merged PR #4670.

Last updated: Oct 23 2024 at 20:03 UTC