Stream: git-wasmtime

Topic: wasmtime / PR #4668 Limit the type hierarchies in compone...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 20:58):

alexcrichton opened PR #4668 from smaller-component-type-fuzzing to main:

For now wasmparser has a hard limit on the size of tuples and such at
1000 recursive types within the tuple itself. Respect this limit by
limiting the width of recursive types generated for the component_api
fuzzer. This commit unifies this new requirement with the preexisting
TupleArray and NonEmptyArray types into one VecInRange<T, L, H>
which allow expressing all of these various requirements in one type.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 17:55):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 17:55):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 17:55):

jameysharp created PR review comment:

I think this is exactly what Unstructured::arbitrary_loop is meant for:

        input.arbitrary_loop(Some(L), Some(H), |input| {
            ret.push(input.arbitrary()?);
            Ok(std::ops::ControlFlow::Continue(()))
        });

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 19:14):

alexcrichton updated PR #4668 from smaller-component-type-fuzzing to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 19:14):

alexcrichton has enabled auto merge for PR #4668.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2022 at 20:49):

alexcrichton merged PR #4668.


Last updated: Nov 22 2024 at 16:03 UTC