Stream: git-wasmtime

Topic: wasmtime / PR #4659 Cranelift: disallow marking entry blo...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 17:36):

cfallin requested elliottt for a review on PR #4659.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 17:36):

cfallin requested fitzgen for a review on PR #4659.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 17:36):

cfallin opened PR #4659 from disallow-cold-entry-blocks to main:

This is a nonsensical constraint: the entry block must come first in the
compiled code's layout, so it cannot also be sunk to the end of the
function.

This PR modifies the CLIF verifier to disallow this situation entirely.
It also adds an assert during final block-order computation to catch the
problem (and avoid a silent miscompile) even if the verifier is
disabled.

Fixes #4656.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 17:55):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 17:55):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 17:55):

elliottt created PR review comment:

Is it worth extracting an issue for this?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 18:03):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 18:03):

cfallin created PR review comment:

This was pre-existing (I un-indented the block containing this comment) but IMHO it's a pretty tiny micro-optimization thought, probably not worth lifting out into an issue. Happy to just remove the comment if you'd prefer :-)

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 18:26):

elliottt created PR review comment:

Seems pretty reasonable to leave it, then :+1:

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 18:26):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2022 at 18:52):

cfallin merged PR #4659.


Last updated: Dec 23 2024 at 13:07 UTC