Wasmtime GitHub notifications bot (Aug 09 2022 at 17:36): Wasmtime GitHub notifications bot (Aug 09 2022 at 17:36):cfallin requested elliottt for a review on PR #4659.
Wasmtime GitHub notifications bot (Aug 09 2022 at 17:36):cfallin requested fitzgen for a review on PR #4659.
Wasmtime GitHub notifications bot (Aug 09 2022 at 17:36):cfallin opened PR #4659 from disallow-cold-entry-blocks to main:
This is a nonsensical constraint: the entry block must come first in the
compiled code's layout, so it cannot also be sunk to the end of the
function.This PR modifies the CLIF verifier to disallow this situation entirely.
It also adds an assert during final block-order computation to catch the
problem (and avoid a silent miscompile) even if the verifier is
disabled.Fixes #4656.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 09 2022 at 17:55):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Aug 09 2022 at 17:55):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Aug 09 2022 at 17:55):elliottt created PR review comment:
Is it worth extracting an issue for this?
Wasmtime GitHub notifications bot (Aug 09 2022 at 18:03):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 09 2022 at 18:03):cfallin created PR review comment:
This was pre-existing (I un-indented the block containing this comment) but IMHO it's a pretty tiny micro-optimization thought, probably not worth lifting out into an issue. Happy to just remove the comment if you'd prefer :-)
Wasmtime GitHub notifications bot (Aug 09 2022 at 18:26):elliottt created PR review comment:
Seems pretty reasonable to leave it, then :+1:
Wasmtime GitHub notifications bot (Aug 09 2022 at 18:26):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Aug 09 2022 at 18:52):cfallin merged PR #4659.
Last updated: Oct 23 2024 at 20:03 UTC