Wasmtime GitHub notifications bot (Aug 09 2022 at 16:43): Wasmtime GitHub notifications bot (Aug 09 2022 at 16:43):alexcrichton opened PR #4658 from deduplicate-size-align to main:
This commit is an effort to reduce the amount of complexity around
managing the size/alignment calculations of types in the canonical ABI.
Previously the logic for the size/alignment of a type was spread out
across a number of locations. While each individual calculation is not
really the most complicated thing in the world having the duplication in
so many places was constantly worrying me.I've opted in this commit to centralize all of this within the runtime
at least, and now there's only one "duplicate" of this information in
the fuzzing infrastructure which is to some degree less important to
deduplicate. This commit introduces a newCanonicalAbiInfotype to
house all abi size/align information for both memory32 and memory64.
This new type is then used pervasively throughout fused adapter
compilation, dynamicValmanagement, and typed functions. This type
was also able to reduce the complexity of the macro-generated code
meaning that evenwasmtime-component-macrois performing less math
than it was before.One other major feature of this commit is that this ABI information is
now saved within aComponentTypesstructure. This avoids recursive
querying of size/align information frequently and instead effectively
caching it. This was a worry I had for the fused adapter compiler which
frequently sought out size/align information and would recursively
descend each type tree each time. Thefact-valid-modulefuzzer is now
nearly 10x faster in terms of iterations/s which I suspect is due to
this caching.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 09 2022 at 16:43):alexcrichton edited PR #4658 from deduplicate-size-align to main:
This commit is an effort to reduce the amount of complexity around
managing the size/alignment calculations of types in the canonical ABI.
Previously the logic for the size/alignment of a type was spread out
across a number of locations. While each individual calculation is not
really the most complicated thing in the world having the duplication in
so many places was constantly worrying me.I've opted in this commit to centralize all of this within the runtime
at least, and now there's only one "duplicate" of this information in
the fuzzing infrastructure which is to some degree less important to
deduplicate. This commit introduces a newCanonicalAbiInfotype to
house all abi size/align information for both memory32 and memory64.
This new type is then used pervasively throughout fused adapter
compilation, dynamicValmanagement, and typed functions. This type
was also able to reduce the complexity of the macro-generated code
meaning that evenwasmtime-component-macrois performing less math
than it was before.One other major feature of this commit is that this ABI information is
now saved within aComponentTypesstructure. This avoids recursive
querying of size/align information frequently and instead effectively
caching it. This was a worry I had for the fused adapter compiler which
frequently sought out size/align information and would recursively
descend each type tree each time. Thefact-valid-modulefuzzer is now
nearly 10x faster in terms of iterations/s which I suspect is due to
this caching.Closes #4592
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 09 2022 at 19:39):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 09 2022 at 19:52):alexcrichton merged PR #4658.
Last updated: Dec 23 2024 at 12:05 UTC