Wasmtime GitHub notifications bot (Aug 09 2022 at 14:51): Wasmtime GitHub notifications bot (Aug 09 2022 at 14:51):alexcrichton requested fitzgen for a review on PR #4657.
Wasmtime GitHub notifications bot (Aug 09 2022 at 14:51):alexcrichton opened PR #4657 from fix-stack-overflow to main:
In #4640 a feature was added to adapter modules that whenever
translation goes through memory it instead goes through a helper
function as opposed to inlining it directly. The generation of the
helper function happened recursively at compile time, however, and sure
enough oss-fuzz has found an input which blows the host stack at compile
time.This commit removes the compile-time recursion from the adapter compiler
when translating these helper functions by deferring the translation to
a worklist which is processed after the original function is translated.
This makes the stack-based recursion instead heap-based, removing the
stack overflow.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 09 2022 at 17:58):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 09 2022 at 17:59):alexcrichton merged PR #4657.
Last updated: Nov 22 2024 at 17:03 UTC