Stream: git-wasmtime

Topic: wasmtime / PR #4650 x64: Migrate fcvt_from_sint and fcvt_...

Wasmtime GitHub notifications bot (Aug 09 2022 at 01:14):

elliottt opened PR #4650 from trevor/x64-fcvt to main:

• Lower cvtdq2ps using the XmmUnaryRmR pseudo-instruction
• Add a test for the existing behavior of fcvt_from_sint
• Migrate fcvt_from_sint to isle
• Add a test for fcvt_low_from_sint
• Lower fcvt_low_from_sint

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 09 2022 at 03:35):

elliottt has marked PR #4650 as ready for review.

Wasmtime GitHub notifications bot (Aug 09 2022 at 03:37):

elliottt edited PR #4650 from trevor/x64-fcvt to main:

Migrate fcvt_from_sint and fcvt_low_from_sint to ISLE. Also support the Cvtdq2ps opcode when emitting XmmUnaryRmR instructions.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 09 2022 at 04:27):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 09 2022 at 04:27):

cfallin created PR review comment:

In addition to adding it here, can we remove it from here and make sure we switch over any uses of that (tweaking any handwritten uses of it in-place is fine for now)? Since the opcode has unary (one src, one dst) semantics it should only appear here, not elsewhere.

I'm also slightly suspect of the two cvt* opcodes above that one in XmmRmR too, and we should see if they should be moved over too, while we're at it...

Wasmtime GitHub notifications bot (Aug 09 2022 at 04:27):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 09 2022 at 19:49):

elliottt updated PR #4650 from trevor/x64-fcvt to main.

Wasmtime GitHub notifications bot (Aug 09 2022 at 20:55):

elliottt updated PR #4650 from trevor/x64-fcvt to main.

Wasmtime GitHub notifications bot (Aug 09 2022 at 21:13):

elliottt updated PR #4650 from trevor/x64-fcvt to main.

Wasmtime GitHub notifications bot (Aug 09 2022 at 22:33):

elliottt updated PR #4650 from trevor/x64-fcvt to main.

Wasmtime GitHub notifications bot (Aug 10 2022 at 00:26):

elliottt updated PR #4650 from trevor/x64-fcvt to main.

Wasmtime GitHub notifications bot (Aug 10 2022 at 17:49):

elliottt merged PR #4650.

Last updated: Dec 23 2024 at 12:05 UTC