Stream: git-wasmtime

Topic: wasmtime / PR #4643 wasmtime: Add a `Config::native_unwin...

Wasmtime GitHub notifications bot (Aug 08 2022 at 19:43):

fitzgen opened PR #4643 from unwind-info-config to main:

This method configures whether native unwind information (e.g. .eh_frame on
Linux) is generated or not.

This helps integrate with third-party stack capturing tools, such as the system
unwinder or the backtrace crate. It does not affect whether Wasmtime can
capture stack traces in Wasm code that it is running or not.

Unwind info is always enabled on Windows, since the Windows ABI requires it.

This configuration option defaults to true.

Additionally, we deprecate Config::wasm_backtrace since we can always cheaply
capture stack traces ever since
https://github.com/bytecodealliance/wasmtime/pull/4431.

Fixes https://github.com/bytecodealliance/wasmtime/issues/4554

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 08 2022 at 19:43):

fitzgen requested alexcrichton for a review on PR #4643.

Wasmtime GitHub notifications bot (Aug 08 2022 at 19:43):

fitzgen requested peterhuene for a review on PR #4643.

Wasmtime GitHub notifications bot (Aug 08 2022 at 19:50):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Aug 08 2022 at 19:55):

fitzgen updated PR #4643 from unwind-info-config to main.

Wasmtime GitHub notifications bot (Aug 08 2022 at 20:45):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 08 2022 at 20:54):

fitzgen merged PR #4643.

Last updated: Nov 22 2024 at 16:03 UTC