Stream: git-wasmtime

Topic: wasmtime / PR #4633 supplement necessary instructions to ...

Wasmtime GitHub notifications bot (Aug 07 2022 at 14:22):

jiang1997 opened PR #4633 from main to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

The instructions in examples/wasi/main.c and examples/wasi/main.rs lack a necessary step to generate wasi.wasm into target/wasm32-wasi/debug/.

Wasmtime GitHub notifications bot (Aug 08 2022 at 15:37):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 08 2022 at 15:37):

alexcrichton merged PR #4633.

Last updated: Nov 22 2024 at 16:03 UTC