Stream: git-wasmtime

Topic: wasmtime / PR #4630 Cranelift: extend docs on Inst to dis...

Wasmtime GitHub notifications bot (Aug 06 2022 at 08:59):

iximeow opened PR #4630 from ixi/inst_call_docs to main:

the docs on Inst note that the type is returned by non-resultful
instructions built from InstBuilder, but did _not_ note that it is
also returned by call and call_indirect. if you're trying to learn
and use Cranelift by following the docs, this means you'd follow a doc
link to Inst that implies that call does not return a value - this
is actively misleading, since you'd want to use the returned Inst to
find exactly those returned values!

so, this adds a few sentences talking about the case of call Insts.

Wasmtime GitHub notifications bot (Aug 06 2022 at 09:00):

iximeow created PR review comment:

i'd be inclined to move this to the front of the paragraph, and leave inventive uses as "and also, here are more exotic uses", but i really don't know how often people are doing builder.ins().call() that they might end up here!

Wasmtime GitHub notifications bot (Aug 06 2022 at 09:00):

iximeow submitted PR review.

Wasmtime GitHub notifications bot (Aug 08 2022 at 18:19):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 08 2022 at 18:19):

cfallin created PR review comment:

Maybe we can put a note here (perhaps instead of below) to the effect of: "... like call or call-indirect instructions. To get the Value results of such an instruction, use inst_results with the returned Inst" ?

Wasmtime GitHub notifications bot (Aug 08 2022 at 18:19):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2022 at 04:31):

iximeow updated PR #4630 from ixi/inst_call_docs to main.

Wasmtime GitHub notifications bot (Aug 22 2022 at 04:32):

iximeow created PR review comment:

admittedly took me a moment to push the change but i really appreciate this suggestion! it cleans up the whole "talk about the normal thing, then the exotic thing, then the normal thing again" wrinkle nicely.

Wasmtime GitHub notifications bot (Aug 22 2022 at 04:32):

iximeow submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2022 at 04:40):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2022 at 15:57):

iximeow merged PR #4630.

Last updated: Oct 23 2024 at 20:03 UTC