Stream: git-wasmtime

Topic: wasmtime / PR #4627 AArch64: don't assert inst within wor...

Wasmtime GitHub notifications bot (Aug 05 2022 at 22:13):

cfallin opened PR #4627 from fix-aarch64-worst-case-size-islands to main:

We assert after emitting each instruction that its size was less than
the "worst-case size", which is used to determine when we need to
proactively emit an island so pending branch fixups don't go out of
bounds. However, the EmitIsland pseudo-inst itself can cause an
arbitrarily large island to be emitted; this should not have to fit
within the worst-case size (because island size is explicitly accounted
for by the threshold computation). This PR fixes the assert accordingly.

Fixes #4626.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 05 2022 at 22:13):

cfallin requested alexcrichton for a review on PR #4627.

Wasmtime GitHub notifications bot (Aug 06 2022 at 00:04):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 06 2022 at 00:27):

cfallin merged PR #4627.

Last updated: Dec 23 2024 at 13:07 UTC