Wasmtime GitHub notifications bot (Aug 05 2022 at 01:01): Wasmtime GitHub notifications bot (Aug 05 2022 at 01:01):alexcrichton opened PR #4622 from fix-dfg-panic to main:
When an adapter module depends on a particular core wasm instance this
means that it actually depends on not only that instance but all prior
core wasm instances as well. This is because core wasm instances must be
instantiated in the specified order within a component and that cannot
change depending on the dataflow between adapters. This commit fixes a
possible panic from linearizing the component dfg where an adapter
module tried to depend on an instance that hadn't been instantiated yet
because the ordering dependency between core wasm instances hadn't been
modeled.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 05 2022 at 01:01):alexcrichton requested peterhuene for a review on PR #4622.
Wasmtime GitHub notifications bot (Aug 05 2022 at 01:05):peterhuene submitted PR review.
Wasmtime GitHub notifications bot (Aug 05 2022 at 01:06):alexcrichton has enabled auto merge for PR #4622.
Wasmtime GitHub notifications bot (Aug 05 2022 at 01:32):alexcrichton merged PR #4622.
Last updated: Oct 23 2024 at 20:03 UTC