Stream: git-wasmtime

Topic: wasmtime / PR #4621 Cranelift: Remove unused `ABICaller::...

Wasmtime GitHub notifications bot (Aug 05 2022 at 00:11):

fitzgen opened PR #4621 from remove-unused-trait-method-and-field to main:

And the ABICallerImpl::ir_sig field that was used to implement that
method. This removes 56 bytes from the size of ABICallerImpl and gives us
speed ups to compilation of about 7% on all benchmarks.

compilation :: nanoseconds :: benchmarks/pulldown-cmark/benchmark.wasm

  Δ = 8205119.48 ± 4069474.25 (confidence = 99%)

  main.so is 0.91x to 0.97x faster than feature.so!
  feature.so is 1.03x to 1.10x faster than main.so!

  [117729152 132258110.36 167484097] main.so
  [107486500 124052990.88 138008797] feature.so

compilation :: nanoseconds :: benchmarks/bz2/benchmark.wasm

  Δ = 4645258.32 ± 1981104.59 (confidence = 99%)

  main.so is 0.92x to 0.97x faster than feature.so!
  feature.so is 1.03x to 1.08x faster than main.so!

  [76562171 85504479.28 93116863] main.so
  [75180650 80859220.96 90591978] feature.so

compilation :: nanoseconds :: benchmarks/spidermonkey/benchmark.wasm

  Δ = 150575617.54 ± 65021102.57 (confidence = 99%)

  main.so is 0.92x to 0.97x faster than feature.so!
  feature.so is 1.03x to 1.08x faster than main.so!

  [2573089039 2843117485.10 3175982602] main.so
  [2559784932 2692541867.56 3143529008] feature.so

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 05 2022 at 00:11):

fitzgen requested cfallin for a review on PR #4621.

Wasmtime GitHub notifications bot (Aug 05 2022 at 16:46):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 05 2022 at 16:46):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 05 2022 at 16:46):

cfallin merged PR #4621.

Last updated: Dec 23 2024 at 12:05 UTC