Stream: git-wasmtime

Topic: wasmtime / PR #4614 x64: Finish migrating brz and brnz to...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:39):

elliottt edited PR #4614 from trevor/x64-isle-brz-brnz to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:40):

elliottt edited PR #4614 from trevor/x64-isle-brz-brnz to main:

Finish migrating the last case for brz and brnz lowering to ISLE in the x64 backend.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:49):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:49):

fitzgen created PR review comment:

Nitpick: I feel like the name could have 64 in it somewhere since this explicitly doesn't handle 32-bit ints/bools/refs.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:49):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:49):

fitzgen created PR review comment:

Wait looking at the implementation, this accepts 32-bit ints/bools, jsut not 32-bit refs. Which I think is fine, but I think means the comment here is misleading.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:52):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:52):

elliottt created PR review comment:

The function I ported over seemed to accept a pretty wide range of types, definitely open to better naming suggestions :)

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:58):

elliottt updated PR #4614 from trevor/x64-isle-brz-brnz to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 18:00):

elliottt has marked PR #4614 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 19:58):

elliottt merged PR #4614.


Last updated: Dec 23 2024 at 12:05 UTC