Wasmtime GitHub notifications bot (Aug 04 2022 at 17:39): Wasmtime GitHub notifications bot (Aug 04 2022 at 17:39):elliottt edited PR #4614 from trevor/x64-isle-brz-brnz to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 04 2022 at 17:40):elliottt edited PR #4614 from trevor/x64-isle-brz-brnz to main:
Finish migrating the last case for
brzandbrnzlowering to ISLE in the x64 backend.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 04 2022 at 17:49):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 04 2022 at 17:49):fitzgen created PR review comment:
Nitpick: I feel like the name could have 64 in it somewhere since this explicitly doesn't handle 32-bit ints/bools/refs.
Wasmtime GitHub notifications bot (Aug 04 2022 at 17:49):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 04 2022 at 17:49):fitzgen created PR review comment:
Wait looking at the implementation, this accepts 32-bit ints/bools, jsut not 32-bit refs. Which I think is fine, but I think means the comment here is misleading.
Wasmtime GitHub notifications bot (Aug 04 2022 at 17:52):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Aug 04 2022 at 17:52):elliottt created PR review comment:
The function I ported over seemed to accept a pretty wide range of types, definitely open to better naming suggestions :)
Wasmtime GitHub notifications bot (Aug 04 2022 at 17:58):elliottt updated PR #4614 from trevor/x64-isle-brz-brnz to main.
Wasmtime GitHub notifications bot (Aug 04 2022 at 18:00):elliottt has marked PR #4614 as ready for review.
Wasmtime GitHub notifications bot (Aug 04 2022 at 19:58):elliottt merged PR #4614.
Last updated: Nov 22 2024 at 17:03 UTC