Wasmtime GitHub notifications bot (Aug 04 2022 at 06:23): Wasmtime GitHub notifications bot (Aug 04 2022 at 06:23):TheGreatRambler opened PR #4606 from android-support to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->This PR adds CMake compilation support (c-api) for Android. From my tests it does function correctly, no unexpected crashes, so no code modifications were made. It uses the
ANDROIDCMake variable to transparently detect when Android compilation is being done and sets flags and some other environment variables accordingly. The environment variables are necessary for some crates (as far as I could tell).BUILD_SHARED_LIBSmight have to be off.Some relevant issues are #3867, #3877, #3921.
Wasmtime GitHub notifications bot (Aug 06 2022 at 04:50):TheGreatRambler updated PR #4606 from android-support to main.
Wasmtime GitHub notifications bot (Aug 23 2022 at 07:18):TheGreatRambler updated PR #4606 from android-support to main.
Wasmtime GitHub notifications bot (Aug 30 2022 at 14:08):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Aug 30 2022 at 14:08):alexcrichton merged PR #4606.
Last updated: Oct 23 2024 at 20:03 UTC