Stream: git-wasmtime

Topic: wasmtime / PR #4605 components: process extract memory in...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 01:21):

peterhuene opened PR #4605 from fix-extract-memory-initializer to main:

This PR fixes an issue where the ExtractMemory initializer wasn't
processed for adapters, leading to incorrect runtime instance indexes in
the initializer resulting from the insertion of adapter instances.

Ultimately this would either resolve the memory from the wrong instance
or panic if the referenced instance didn't export a memory when
instantiating the component.

The fix is to fixup the memory export's instance when processing global
initializers.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 01:21):

peterhuene requested alexcrichton for a review on PR #4605.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 15:07):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 05 2022 at 00:35):

peterhuene updated PR #4605 from fix-extract-memory-initializer to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 05 2022 at 01:06):

peterhuene closed without merge PR #4605.

Last updated: Dec 23 2024 at 12:05 UTC