Wasmtime GitHub notifications bot (Aug 03 2022 at 01:44): Wasmtime GitHub notifications bot (Aug 03 2022 at 01:44):teymour-aldridge opened PR #4588 from try_use_var to main:
Please ensure that the following steps are all taken care of before submitting
the PR.
- [x] This is a very small PR, so I have no created an issue
[x] A frontend might want to provide its own error reporting to end users if the variable does not exist.
first.[x]
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.
Wasmtime GitHub notifications bot (Aug 03 2022 at 01:45):teymour-aldridge edited PR #4588 from try_use_var to main:
Please ensure that the following steps are all taken care of before submitting
the PR.
- [x] This is a very small PR, so I have no created an issue
[x] A frontend might want to provide its own error reporting to end users if the variable does not exist.
first.[x] @cfallin (maybe?)
Wasmtime GitHub notifications bot (Aug 03 2022 at 06:37):afonso360 submitted PR review.
Wasmtime GitHub notifications bot (Aug 03 2022 at 06:37):afonso360 submitted PR review.
Wasmtime GitHub notifications bot (Aug 03 2022 at 06:37):afonso360 created PR review comment:
This should also impl Error and Display so that callers can easily use ? on it.
Wasmtime GitHub notifications bot (Aug 03 2022 at 09:41):teymour-aldridge updated PR #4588 from try_use_var to main.
Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):cfallin created PR review comment:
Add a period at the end of this description?
Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):cfallin created PR review comment:
likewise here,
write!is much more idiomatic.
Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):cfallin created PR review comment:
Here you should be able to do
write!(f, "variable {} was declared multiple times", variable.index()).
Wasmtime GitHub notifications bot (Aug 04 2022 at 00:59):teymour-aldridge updated PR #4588 from try_use_var to main.
Wasmtime GitHub notifications bot (Aug 04 2022 at 15:28):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 04 2022 at 15:28):cfallin created PR review comment:
Here too we should use
write!and not the manual unrolling of it.
Wasmtime GitHub notifications bot (Aug 04 2022 at 15:31):teymour-aldridge updated PR #4588 from try_use_var to main.
Wasmtime GitHub notifications bot (Aug 04 2022 at 15:31):teymour-aldridge created PR review comment:
Sorry, I missed this one!
Wasmtime GitHub notifications bot (Aug 04 2022 at 15:31):teymour-aldridge submitted PR review.
Wasmtime GitHub notifications bot (Aug 04 2022 at 15:43):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 04 2022 at 15:44):cfallin has enabled auto merge for PR #4588.
Wasmtime GitHub notifications bot (Aug 04 2022 at 16:07):teymour-aldridge edited PR #4588 from try_use_var to main:
Please ensure that the following steps are all taken care of before submitting
the PR.
- [x] This is a very small PR, so I have not created an issue
[x] A frontend might want to provide its own error reporting to end users if the variable does not exist.
first.[x] @cfallin (maybe?)
Wasmtime GitHub notifications bot (Aug 04 2022 at 16:07):teymour-aldridge edited PR #4588 from try_use_var to main:
Please ensure that the following steps are all taken care of before submitting
the PR.
- [x] This is a very small PR, so I have not created an issue
- [x] A frontend might want to provide its own error reporting to end users if the variable does not exist.
- [x] @cfallin (maybe?)
Wasmtime GitHub notifications bot (Aug 04 2022 at 16:19):cfallin merged PR #4588.
Last updated: Nov 22 2024 at 16:03 UTC