Stream: git-wasmtime

Topic: wasmtime / PR #4588 Add `try_use_var` method to `cranelif...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 01:44):

teymour-aldridge opened PR #4588 from try_use_var to main:

Please ensure that the following steps are all taken care of before submitting
the PR.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 01:45):

teymour-aldridge edited PR #4588 from try_use_var to main:

Please ensure that the following steps are all taken care of before submitting
the PR.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 06:37):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 06:37):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 06:37):

afonso360 created PR review comment:

This should also impl Error and Display so that callers can easily use ? on it.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 09:41):

teymour-aldridge updated PR #4588 from try_use_var to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):

cfallin created PR review comment:

Add a period at the end of this description?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):

cfallin created PR review comment:

likewise here, write! is much more idiomatic.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 17:40):

cfallin created PR review comment:

Here you should be able to do write!(f, "variable {} was declared multiple times", variable.index()).

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 00:59):

teymour-aldridge updated PR #4588 from try_use_var to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 15:28):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 15:28):

cfallin created PR review comment:

Here too we should use write! and not the manual unrolling of it.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 15:31):

teymour-aldridge updated PR #4588 from try_use_var to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 15:31):

teymour-aldridge created PR review comment:

Sorry, I missed this one!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 15:31):

teymour-aldridge submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 15:43):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 15:44):

cfallin has enabled auto merge for PR #4588.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 16:07):

teymour-aldridge edited PR #4588 from try_use_var to main:

Please ensure that the following steps are all taken care of before submitting
the PR.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 16:07):

teymour-aldridge edited PR #4588 from try_use_var to main:

Please ensure that the following steps are all taken care of before submitting
the PR.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 16:19):

cfallin merged PR #4588.


Last updated: Dec 23 2024 at 12:05 UTC