Wasmtime GitHub notifications bot (Aug 03 2022 at 00:01): Wasmtime GitHub notifications bot (Aug 03 2022 at 00:01):elliottt opened PR #4587 from trevor/x64-isle-br to main:
- Lower the jump instruction in isle
- Migrate brif, and some cases of brz and brnz
- Migrate br_icond
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 03 2022 at 00:08):elliottt updated PR #4587 from trevor/x64-isle-br to main.
Wasmtime GitHub notifications bot (Aug 03 2022 at 16:28):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 03 2022 at 16:28):fitzgen created PR review comment:
Could you add a little doc comment for this? Something like
;; Match a label slice of length one, extracting the only label in the slice.
Wasmtime GitHub notifications bot (Aug 03 2022 at 16:28):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 03 2022 at 16:28):fitzgen created PR review comment:
Similar doc comment here please.
Wasmtime GitHub notifications bot (Aug 03 2022 at 18:59):elliottt updated PR #4587 from trevor/x64-isle-br to main.
Wasmtime GitHub notifications bot (Aug 03 2022 at 19:01):elliottt edited PR #4587 from trevor/x64-isle-br to main:
Begin migrating branch instructions for the x64 backend to ISLE.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 03 2022 at 19:01):elliottt has marked PR #4587 as ready for review.
Wasmtime GitHub notifications bot (Aug 03 2022 at 19:02):elliottt updated PR #4587 from trevor/x64-isle-br to main.
Wasmtime GitHub notifications bot (Aug 03 2022 at 19:08):elliottt updated PR #4587 from trevor/x64-isle-br to main.
Wasmtime GitHub notifications bot (Aug 03 2022 at 19:48):elliottt updated PR #4587 from trevor/x64-isle-br to main.
Wasmtime GitHub notifications bot (Aug 03 2022 at 20:15):elliottt has enabled auto merge for PR #4587.
Wasmtime GitHub notifications bot (Aug 03 2022 at 20:28):elliottt merged PR #4587.
Last updated: Dec 23 2024 at 13:07 UTC