Stream: git-wasmtime

Topic: wasmtime / PR #4586 Use a `SmallVec` for `ABIArgSlot`s

Wasmtime GitHub notifications bot (Aug 02 2022 at 22:54):

fitzgen requested cfallin for a review on PR #4586.

Wasmtime GitHub notifications bot (Aug 02 2022 at 22:54):

fitzgen opened PR #4586 from abi-arg-slot-small-vec to main:

These are always length 1 for Wasm benchmarks.

<h3>Sightglass Benchmark Results</h3>

compilation :: nanoseconds :: benchmarks/spidermonkey/benchmark.wasm

  Δ = 328624015.86 ± 40274677.93 (confidence = 99%)

  main.so is 0.88x to 0.91x faster than slots-smallvec.so!
  slots-smallvec.so is 1.10x to 1.13x faster than main.so!

  [3070752447 3203778792.55 3446269274] main.so
  [2503544039 2875154776.69 3197966713] slots-smallvec.so

compilation :: nanoseconds :: benchmarks/pulldown-cmark/benchmark.wasm

  Δ = 9685705.06 ± 3221286.87 (confidence = 99%)

  main.so is 0.91x to 0.96x faster than slots-smallvec.so!
  slots-smallvec.so is 1.05x to 1.09x faster than main.so!

  [129356493 145594942.79 165038803] main.so
  [118555011 135909237.73 188780619] slots-smallvec.so

compilation :: nanoseconds :: benchmarks/bz2/benchmark.wasm

  No difference in performance.

  [79080493 86757564.46 112649639] main.so
  [78083384 85934125.69 94992743] slots-smallvec.so

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 02 2022 at 23:15):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 03 2022 at 00:40):

fitzgen merged PR #4586.

Last updated: Dec 23 2024 at 12:05 UTC