fitzgen opened PR #4583 from externref-logging
to main
:
I essentially add these same logs back in every time I'm debugging something
related to this fuzz target orexternref
s in general. Probably like 5 times
I've added roughly these logs. We should just make them available whenever we
need them viaRUST_LOG=wasmtime_runtime=trace
.This also changes a couple
if let
s tounwrap
s that are now infallible after<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen requested alexcrichton for a review on PR #4583.
fitzgen edited PR #4583 from externref-logging
to main
:
I essentially add these same logs back in every time I'm debugging something
related to this fuzz target orexternref
s in general. Probably like 5 times
I've added roughly these logs. We should just make them available whenever we
need them viaRUST_LOG=wasmtime_runtime=trace
.This also changes a couple
if let
s tounwrap
s that are now infallible after #4431.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
alexcrichton submitted PR review.
fitzgen merged PR #4583.
Last updated: Dec 23 2024 at 12:05 UTC