Stream: git-wasmtime

Topic: wasmtime / PR #4583 wasmtime: Add lots of logging for `ex...

Wasmtime GitHub notifications bot (Aug 02 2022 at 20:24):

fitzgen opened PR #4583 from externref-logging to main:

I essentially add these same logs back in every time I'm debugging something
related to this fuzz target or externrefs in general. Probably like 5 times
I've added roughly these logs. We should just make them available whenever we
need them via RUST_LOG=wasmtime_runtime=trace.

This also changes a couple if lets to unwraps that are now infallible after

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 02 2022 at 20:24):

fitzgen requested alexcrichton for a review on PR #4583.

Wasmtime GitHub notifications bot (Aug 02 2022 at 20:25):

fitzgen edited PR #4583 from externref-logging to main:

I essentially add these same logs back in every time I'm debugging something
related to this fuzz target or externrefs in general. Probably like 5 times
I've added roughly these logs. We should just make them available whenever we
need them via RUST_LOG=wasmtime_runtime=trace.

This also changes a couple if lets to unwraps that are now infallible after #4431.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 02 2022 at 20:34):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 02 2022 at 22:06):

fitzgen merged PR #4583.

Last updated: Nov 22 2024 at 16:03 UTC