Stream: git-wasmtime

Topic: wasmtime / PR #4581 Improve readability of memory64 compa...

Wasmtime GitHub notifications bot (Aug 02 2022 at 19:42):

alexcrichton opened PR #4581 from fact-memory64-readable to main:

This commit aims to improve the readability of supporting the memory64
proposal in the fact adapter trampoline compiler. Previously there
were a few sprinkled blocks that used if to generate different
instructions inline, but as I've worked on support for strings this has
become pretty unwieldy as strings do far more memory manipulation than
other type conversions. A pattern that's easier to read is to have
small instruction helpers that take the pointer width as an argument and
internally dispatch to the correct instruction. This keeps the main
translation code branch-free and a bit easier to follow. Additionally
for more complicated branching logic it allows for deduplicating the
main translation path by having lots of little branches instead of one
large branch with everything duplicated on both halves.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 02 2022 at 21:59):

alexcrichton requested fitzgen for a review on PR #4581.

Wasmtime GitHub notifications bot (Aug 03 2022 at 16:13):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 03 2022 at 16:14):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 03 2022 at 16:22):

alexcrichton updated PR #4581 from fact-memory64-readable to main.

Wasmtime GitHub notifications bot (Aug 03 2022 at 16:23):

alexcrichton has enabled auto merge for PR #4581.

Wasmtime GitHub notifications bot (Aug 03 2022 at 17:12):

alexcrichton merged PR #4581.

Last updated: Dec 23 2024 at 12:05 UTC