Wasmtime GitHub notifications bot (Aug 02 2022 at 14:44): Wasmtime GitHub notifications bot (Aug 02 2022 at 14:44):uweigand opened PR #4576 from extend-stackarg to main:
The gen_copy_arg_to_regs routine currently ignores argument extension
flags when loading incoming arguments. This causes a problem with
stack arguments on big-endian systems, since the argument address
points to the word on the stack as extended by the caller, but the
generated code only loads the inner type from the address, causing
it to receive an incorrect value. (This happens to work on little-
endian systems.)Fixed by loading extended arguments as full words.
FYI @cfallin
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 02 2022 at 20:54):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 02 2022 at 20:54):cfallin merged PR #4576.
Last updated: Dec 23 2024 at 12:05 UTC