Stream: git-wasmtime

Topic: wasmtime / PR #4572 Cranelift: don't `emit` inside loweri...

Wasmtime GitHub notifications bot (Aug 01 2022 at 22:45):

fitzgen opened PR #4572 from side-effect-free-aarch64-lower to main:

The lowering rules should be "pure", "declarative" and side-effect free, using helpers defined in inst.isle to perform/encapsulate actual side effects like emitting instructions.

See https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/docs/isle-integration.md#lowering-rules-are-always-pure-use-ssa for some more details/guidance here.

cc @dheaton-arm, since you were the original author. Not a big deal, just fyi for the future.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 01 2022 at 22:45):

fitzgen requested cfallin for a review on PR #4572.

Wasmtime GitHub notifications bot (Aug 01 2022 at 23:03):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 01 2022 at 23:43):

fitzgen merged PR #4572.

Last updated: Dec 23 2024 at 12:05 UTC