elliottt opened PR #4561 from trevor/log-isle-failure
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt edited PR #4561 from trevor/log-isle-failure
to main
:
When ISLE constructors fail to apply we currently return
None
with no additional information about what rule failed. To help with debugging, this PR adds an additional codegen flag calledmatch_failure_traces
which will emitlog::trace!
calls everywhere a pattern match failure is possible.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt requested cfallin for a review on PR #4561.
elliottt has marked PR #4561 as ready for review.
elliottt edited PR #4561 from trevor/log-isle-failure
to main
:
When ISLE constructors fail to apply we currently return
None
with no additional information about what rule failed. To help with debugging, this PR adds an additional codegen flag calledmatch_failure_tracing
which will emitlog::trace!
calls everywhere a pattern match failure is possible.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
cfallin submitted PR review.
cfallin submitted PR review.
cfallin created PR review comment:
Is this assignment necessary, if
false
is already the default? (Or alternately, did you mean to make ittrue
so debugging trests is easier?)
elliottt created PR review comment:
:facepalm:
thanks for catching that :)
elliottt submitted PR review.
elliottt updated PR #4561 from trevor/log-isle-failure
to main
.
elliottt updated PR #4561 from trevor/log-isle-failure
to main
.
elliottt updated PR #4561 from trevor/log-isle-failure
to main
.
elliottt requested cfallin for a review on PR #4561.
elliottt closed without merge PR #4561.
Last updated: Dec 23 2024 at 12:05 UTC