Stream: git-wasmtime

Topic: wasmtime / PR #4561 Optionally add `log::trace!` calls wh...

Wasmtime GitHub notifications bot (Jul 29 2022 at 22:46):

elliottt opened PR #4561 from trevor/log-isle-failure to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 29 2022 at 22:48):

elliottt edited PR #4561 from trevor/log-isle-failure to main:

When ISLE constructors fail to apply we currently return None with no additional information about what rule failed. To help with debugging, this PR adds an additional codegen flag called match_failure_traces which will emit log::trace! calls everywhere a pattern match failure is possible.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 29 2022 at 22:48):

elliottt requested cfallin for a review on PR #4561.

Wasmtime GitHub notifications bot (Jul 29 2022 at 22:48):

elliottt has marked PR #4561 as ready for review.

Wasmtime GitHub notifications bot (Jul 29 2022 at 22:48):

elliottt edited PR #4561 from trevor/log-isle-failure to main:

When ISLE constructors fail to apply we currently return None with no additional information about what rule failed. To help with debugging, this PR adds an additional codegen flag called match_failure_tracing which will emit log::trace! calls everywhere a pattern match failure is possible.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 29 2022 at 23:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 29 2022 at 23:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 29 2022 at 23:01):

cfallin created PR review comment:

Is this assignment necessary, if false is already the default? (Or alternately, did you mean to make it true so debugging trests is easier?)

Wasmtime GitHub notifications bot (Jul 29 2022 at 23:38):

elliottt created PR review comment:

:facepalm: thanks for catching that :)

Wasmtime GitHub notifications bot (Jul 29 2022 at 23:38):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jul 29 2022 at 23:40):

elliottt updated PR #4561 from trevor/log-isle-failure to main.

Wasmtime GitHub notifications bot (Sep 08 2022 at 18:28):

elliottt updated PR #4561 from trevor/log-isle-failure to main.

Wasmtime GitHub notifications bot (Sep 08 2022 at 18:41):

elliottt updated PR #4561 from trevor/log-isle-failure to main.

Wasmtime GitHub notifications bot (Sep 08 2022 at 18:45):

elliottt requested cfallin for a review on PR #4561.

Wasmtime GitHub notifications bot (Sep 20 2022 at 23:01):

elliottt closed without merge PR #4561.

Last updated: Nov 22 2024 at 17:03 UTC