Stream: git-wasmtime

Topic: wasmtime / PR #4558 Implement fused adapters for `(list T...

Wasmtime GitHub notifications bot (Jul 29 2022 at 19:08):

alexcrichton opened PR #4558 from adapt-list to main:

This commit implements one of the two remaining types for adapter
fusion, lists. This implementation is particularly tricky for a number
of reasons:

• Lists have a number of validity checks which need to be carefully
  implemented. For example the byte length of the list passed to
  allocation in the destination module could overflow the 32-bit index
  space. Additionally lists in 32-bit memories need a check that their
  final address is in-bounds in the address space.

• In the effort to go ahead and support memory64 at the lowest layers
  this is where much of the magic happens. Lists are naturally always
  stored in memory and shifting between 64/32-bit address spaces
  is done here. This notably required plumbing an Options around
  during flattening/size/alignment calculations due to the size/types of
  lists changing depending on the memory configuration.

I've also added a small factc program in this commit which should
hopefully assist in exploring and debugging adapter modules. This takes
as input a component (text or binary format) and then generates an
adapter module for all component function signatures found internally.

This commit notably does not include tests for lists. I tried to figure
out a good way to add these but I felt like there were too many cases to
test and the tests would otherwise be extremely verbose. Instead I think
the best testing strategy for this commit will be through #4537 which
should be relatively extensible to testing adapters between modules in
addition to host-based lifting/lowering.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 29 2022 at 19:08):

alexcrichton requested fitzgen for a review on PR #4558.

Wasmtime GitHub notifications bot (Jul 29 2022 at 19:08):

alexcrichton has marked PR #4558 as ready for review.

Wasmtime GitHub notifications bot (Jul 29 2022 at 19:37):

alexcrichton updated PR #4558 from adapt-list to main.

Wasmtime GitHub notifications bot (Aug 01 2022 at 18:02):

alexcrichton updated PR #4558 from adapt-list to main.

Wasmtime GitHub notifications bot (Aug 01 2022 at 20:34):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 01 2022 at 22:02):

alexcrichton merged PR #4558.

Last updated: Nov 22 2024 at 16:03 UTC