Stream: git-wasmtime

Topic: wasmtime / PR #4558 Implement fused adapters for `(list T...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2022 at 19:08):

alexcrichton opened PR #4558 from adapt-list to main:

This commit implements one of the two remaining types for adapter
fusion, lists. This implementation is particularly tricky for a number
of reasons:

I've also added a small factc program in this commit which should
hopefully assist in exploring and debugging adapter modules. This takes
as input a component (text or binary format) and then generates an
adapter module for all component function signatures found internally.

This commit notably does not include tests for lists. I tried to figure
out a good way to add these but I felt like there were too many cases to
test and the tests would otherwise be extremely verbose. Instead I think
the best testing strategy for this commit will be through #4537 which
should be relatively extensible to testing adapters between modules in
addition to host-based lifting/lowering.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2022 at 19:08):

alexcrichton requested fitzgen for a review on PR #4558.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2022 at 19:08):

alexcrichton has marked PR #4558 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2022 at 19:37):

alexcrichton updated PR #4558 from adapt-list to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 01 2022 at 18:02):

alexcrichton updated PR #4558 from adapt-list to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 01 2022 at 20:34):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 01 2022 at 22:02):

alexcrichton merged PR #4558.


Last updated: Dec 23 2024 at 12:05 UTC