Stream: git-wasmtime

Topic: wasmtime / PR #4544 Implement `char` type in adapter fusion

Wasmtime GitHub notifications bot (Jul 27 2022 at 23:15):

alexcrichton opened PR #4544 from adapt-char to main:

This commit implements the translation of char which validates that
it's in the valid range of unicode scalar values. The precise validation
here is lifted from LLVM in the hopes that it's probably better than
whatever I would concoct by hand.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 27 2022 at 23:15):

alexcrichton has marked PR #4544 as ready for review.

Wasmtime GitHub notifications bot (Jul 27 2022 at 23:15):

alexcrichton requested fitzgen for a review on PR #4544.

Wasmtime GitHub notifications bot (Jul 28 2022 at 16:32):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 28 2022 at 16:47):

alexcrichton merged PR #4544.

Last updated: Dec 23 2024 at 13:07 UTC