Wasmtime GitHub notifications bot (Jul 27 2022 at 18:01): Wasmtime GitHub notifications bot (Jul 27 2022 at 18:01):elliottt opened PR #4542 from trevor/x64-lower-call to main:
- Migrate call and call_indirect to ISLE
- Update tests
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 27 2022 at 18:04):elliottt updated PR #4542 from trevor/x64-lower-call to main.
Wasmtime GitHub notifications bot (Jul 27 2022 at 18:07):elliottt updated PR #4542 from trevor/x64-lower-call to main.
Wasmtime GitHub notifications bot (Jul 27 2022 at 18:10):elliottt edited PR #4542 from trevor/x64-lower-call to main:
Migrate the lowerings for
callandcall_indirectto ISLE. This is a less thorough embedding of those two lowerings in ISLE than the s390x backend, but we can re-evaluate that decision later.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 27 2022 at 19:41):elliottt has marked PR #4542 as ready for review.
Wasmtime GitHub notifications bot (Jul 28 2022 at 00:21):elliottt requested cfallin for a review on PR #4542.
Wasmtime GitHub notifications bot (Jul 28 2022 at 00:46):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jul 28 2022 at 00:46):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jul 28 2022 at 00:46):cfallin created PR review comment:
It doesn't look like this is actually invoked from ISLE -- I guess it's here so it can be in the
Contexttrait and so the impl can sit next to its user inisle.rs?I think I'd prefer to move it to a separate
impl IsleContextblock (ie not the trait impl) and avoid listing it here, just to avoid confusion ("why is this an extractor, where is it used?") if for no other reason...
Wasmtime GitHub notifications bot (Jul 28 2022 at 00:46):cfallin created PR review comment:
Let's have a
panichere instead: in theory we could have a larger number if we have a narrower machine (I128on a 32-bit architecture) or larger type. Otherwise we just fail isel in a hard-to-debug way...
Wasmtime GitHub notifications bot (Jul 28 2022 at 02:16):elliottt created PR review comment:
When my previous attempt had more of the lowering implemented in ISLE, I was using it there. I agree that it's odd to see it here, only to be used from the rust side -- we can always add it back to the prelude if it turns out it's necessary.
Wasmtime GitHub notifications bot (Jul 28 2022 at 02:16):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Jul 28 2022 at 02:18):elliottt updated PR #4542 from trevor/x64-lower-call to main.
Wasmtime GitHub notifications bot (Jul 28 2022 at 02:21):elliottt updated PR #4542 from trevor/x64-lower-call to main.
Wasmtime GitHub notifications bot (Jul 28 2022 at 20:10):elliottt merged PR #4542.
Last updated: Nov 22 2024 at 16:03 UTC