Stream: git-wasmtime

Topic: wasmtime / PR #4533 x64: only enable VTune dependencies o...

Wasmtime GitHub notifications bot (Jul 26 2022 at 18:19):

abrown opened PR #4533 from conditional-vtune to main:

As described in #4523, the ittapi dependency necessary for Wasmtime's
VTune support does not compile on aarch64-linux-android. There are
several incompatible parts here: though ittapi supports all OS
combinations that Wasmtime does and builds on all CPU targets, VTune is
not primarily intended for aarch64 profiling and linux-android is not
a high priority platform for the library. We could conditionally depend
on ittapi for Wasmtime's supported OS combinations, but I think a
better answer is to limit it to x86_64 targets, since this more clearly
shows why the ittapi/VTune support is present and also fixes

Wasmtime GitHub notifications bot (Jul 26 2022 at 18:19):

abrown edited PR #4533 from conditional-vtune to main:

As described in #4523, the ittapi dependency necessary for Wasmtime's
VTune support does not compile on aarch64-linux-android. There are
several incompatible parts here: though ittapi supports all OS
combinations that Wasmtime does and builds on all CPU targets, VTune is
not primarily intended for aarch64 profiling and linux-android is not
a high priority platform for the library. We could conditionally depend
on ittapi for Wasmtime's supported OS combinations, but I think a
better answer is to limit it to x86_64 targets, since this more clearly
shows why the ittapi/VTune support is present and also fixes #4523.

Wasmtime GitHub notifications bot (Jul 26 2022 at 18:20):

abrown updated PR #4533 from conditional-vtune to main.

Wasmtime GitHub notifications bot (Jul 26 2022 at 20:07):

abrown has marked PR #4533 as ready for review.

Wasmtime GitHub notifications bot (Jul 26 2022 at 20:40):

abrown requested alexcrichton for a review on PR #4533.

Wasmtime GitHub notifications bot (Jul 28 2022 at 14:22):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 28 2022 at 14:22):

alexcrichton merged PR #4533.

Last updated: Nov 22 2024 at 16:03 UTC