Stream: git-wasmtime

Topic: wasmtime / PR #4531 Don't try to report file size or time...

Wasmtime GitHub notifications bot (Jul 26 2022 at 15:54):

sunfishcode opened PR #4531 from stdio-stat to main:

Calling File::metadata() on a stdio stream handle fails on Windows, where
the stdio streams are not files.

This File::metadata() call was effectively only being used to add file size
and timestamps to the result of filestat_get. It's common for users to
redirect stdio streams to interesting places, and applications
generally shouldn't change their behavior depending on the size or
timestamps of the file, if the streams are redirected to a file, so just
leave these fields to 0, which is commonly understood to represent
"unknown".

Fixes #4497.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 26 2022 at 16:03):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 26 2022 at 16:44):

sunfishcode updated PR #4531 from stdio-stat to main.

Wasmtime GitHub notifications bot (Jul 26 2022 at 22:53):

sunfishcode merged PR #4531.

Last updated: Nov 22 2024 at 16:03 UTC