Stream: git-wasmtime

Topic: wasmtime / PR #4531 Don't try to report file size or time...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2022 at 15:54):

sunfishcode opened PR #4531 from stdio-stat to main:

Calling File::metadata() on a stdio stream handle fails on Windows, where
the stdio streams are not files.

This File::metadata() call was effectively only being used to add file size
and timestamps to the result of filestat_get. It's common for users to
redirect stdio streams to interesting places, and applications
generally shouldn't change their behavior depending on the size or
timestamps of the file, if the streams are redirected to a file, so just
leave these fields to 0, which is commonly understood to represent
"unknown".

Fixes #4497.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2022 at 16:03):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2022 at 16:44):

sunfishcode updated PR #4531 from stdio-stat to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2022 at 22:53):

sunfishcode merged PR #4531.


Last updated: Dec 23 2024 at 12:05 UTC