Stream: git-wasmtime

Topic: wasmtime / PR #4519 cranelift: Fix shifts and implement r...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 24 2022 at 09:47):

afonso360 opened PR #4519 from interp-shifts to main:

:wave: Hey,

This PR fixes some issues with shifts in the interpreter and implements rotates.

It also fixes some issues with the x64 implementation where some type combinations for rotl/rotr were not lowered.

cc: @jameysharp @cfallin

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 00:24):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 00:24):

jameysharp created PR review comment:

I really appreciate that you not only tracked down where these particular tests came from, but also left a link here in case anybody else wonders!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 00:24):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 14:17):

afonso360 updated PR #4519 from interp-shifts to main.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 19:15):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 19:15):

cfallin merged PR #4519.

Last updated: Nov 22 2024 at 16:03 UTC