Stream: git-wasmtime

Topic: wasmtime / PR #4518 x64: Migrate the return and fallthrou...

Wasmtime GitHub notifications bot (Jul 23 2022 at 23:36):

elliottt opened PR #4518 from trevor/x64-lower-return to main:

Migrate the return and fallthrough_return lowerings to ISLE. Also add some additional utility functions for working with ValueRegs, WritableValueRegs, and Range types.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 25 2022 at 18:08):

elliottt edited PR #4518 from trevor/x64-lower-return to main:

Migrate the return and fallthrough_return lowerings to ISLE. Also add some additional utility functions for working with ValueRegs, WritableValueRegs, and Range types in ISLE.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 25 2022 at 18:08):

elliottt has marked PR #4518 as ready for review.

Wasmtime GitHub notifications bot (Jul 25 2022 at 18:13):

elliottt updated PR #4518 from trevor/x64-lower-return to main.

Wasmtime GitHub notifications bot (Jul 25 2022 at 19:39):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 25 2022 at 19:39):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 25 2022 at 19:39):

cfallin created PR review comment:

Could we move the comment here "N.B.: the Ret itself is generated by the ABI" from the original? Otherwise it's somewhat unclear to the reader why return and fallthrougth_return should be identical, and why they only set up the return value rather than really returning.

Wasmtime GitHub notifications bot (Jul 25 2022 at 20:19):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jul 25 2022 at 20:19):

elliottt created PR review comment:

Great point, I'll add that.

Wasmtime GitHub notifications bot (Jul 25 2022 at 20:21):

elliottt updated PR #4518 from trevor/x64-lower-return to main.

Wasmtime GitHub notifications bot (Jul 25 2022 at 20:22):

elliottt updated PR #4518 from trevor/x64-lower-return to main.

Wasmtime GitHub notifications bot (Jul 25 2022 at 21:28):

elliottt has enabled auto merge for PR #4518.

Wasmtime GitHub notifications bot (Jul 25 2022 at 21:28):

elliottt merged PR #4518.

Last updated: Nov 22 2024 at 16:03 UTC