elliottt opened PR #4518 from trevor/x64-lower-return
to main
:
Migrate the
return
andfallthrough_return
lowerings to ISLE. Also add some additional utility functions for working withValueRegs
,WritableValueRegs
, andRange
types.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt edited PR #4518 from trevor/x64-lower-return
to main
:
Migrate the
return
andfallthrough_return
lowerings to ISLE. Also add some additional utility functions for working withValueRegs
,WritableValueRegs
, andRange
types in ISLE.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt has marked PR #4518 as ready for review.
elliottt updated PR #4518 from trevor/x64-lower-return
to main
.
cfallin submitted PR review.
cfallin submitted PR review.
cfallin created PR review comment:
Could we move the comment here "N.B.: the Ret itself is generated by the ABI" from the original? Otherwise it's somewhat unclear to the reader why
return
andfallthrougth_return
should be identical, and why they only set up the return value rather than really returning.
elliottt submitted PR review.
elliottt created PR review comment:
Great point, I'll add that.
elliottt updated PR #4518 from trevor/x64-lower-return
to main
.
elliottt updated PR #4518 from trevor/x64-lower-return
to main
.
elliottt has enabled auto merge for PR #4518.
elliottt merged PR #4518.
Last updated: Dec 23 2024 at 12:05 UTC