Stream: git-wasmtime

Topic: wasmtime / PR #4517 cranelift: Add MinGW `fma` regression...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2022 at 17:03):

afonso360 opened PR #4517 from mingw-fma-regress to main:

See #4512 for context.

It looks like MinGW has an incorrect implementation of fma. This did not show up in the current fma test suite, but it did show when @alexcrichton tried to upgrade to windows-latest on CI.

In this PR we just add the test cases that were submitted to the original bug report of MinGW.

Opening this as a draft, and eventually we'll add a fix for this as well.

cc: @cfallin @alexcrichton

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2022 at 17:08):

afonso360 updated PR #4517 from mingw-fma-regress to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2022 at 17:18):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2022 at 06:59):

afonso360 updated PR #4517 from mingw-fma-regress to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2022 at 06:59):

afonso360 has marked PR #4517 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2022 at 07:03):

afonso360 updated PR #4517 from mingw-fma-regress to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2022 at 09:29):

afonso360 requested alexcrichton for a review on PR #4517.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2022 at 14:09):

alexcrichton merged PR #4517.

Last updated: Oct 23 2024 at 20:03 UTC