Stream: git-wasmtime

Topic: wasmtime / PR #4516 s390x: Enable more runtests, and fix ...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2022 at 16:47):

uweigand opened PR #4516 from s390x-runtests to main:

This enables more runtests to be executed on s390x. Doing so
uncovered a two back-end bugs, which are fixed as well:

In addition, I found a bug in the load-op-store.clif test case:
v3 = heap_addr.i64 heap0, v1, 4
v4 = iconst.i64 42
store.i32 v4, v3
This was clearly intended to perform a 32-bit store, but
actually performs a 64-bit store (it seems the type annotation
of the store opcode is ignored, and the type of the operand
is used instead). That bug did not show any noticable symptoms
on little-endian architectures, but broke on big-endian.

FYI @cfallin @afonso360

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2022 at 19:37):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2022 at 19:37):

cfallin merged PR #4516.


Last updated: Dec 23 2024 at 12:05 UTC