Stream: git-wasmtime

Topic: wasmtime / PR #4510 cranelift: Restrict `br_table` to `i3...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 15:29):

afonso360 opened PR #4510 from brtable-i32 to main:

:wave: Hey,

In #4498 it was proposed that we should only accept i32 indices to br_table. The rationale for this is that larger types lead the users to a false sense of flexibility (since we don't support jump tables larger than u32's), and narrower types are not well tested paths that would be safer if we removed them.

Fixes #4498
CC: @jameysharp @bjorn3 @cfallin

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 17:22):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 17:22):

bjorn3 created PR review comment:

I believe ireduce can directly go from i128 to i32.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 17:44):

afonso360 updated PR #4510 from brtable-i32 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 18:44):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 21:52):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 22:50):

afonso360 updated PR #4510 from brtable-i32 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 23:08):

jameysharp has enabled auto merge for PR #4510.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 23:32):

jameysharp merged PR #4510.

Last updated: Nov 22 2024 at 16:03 UTC