Stream: git-wasmtime

Topic: wasmtime / PR #4506 cranelift: Fix `icmp_imm` for small t...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 09:03):

afonso360 opened PR #4506 from interp-icmp-imm-fix to main:

:wave: Hey,

This was discovered by fuzzgen after fixing the switch API.

This PR also enables a bunch of icmp tests for s390x that were probably forgotten.

CC: #4502
CC: @jameysharp

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 12:03):

afonso360 updated PR #4506 from interp-icmp-imm-fix to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 12:04):

afonso360 has marked PR #4506 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 23:30):

jameysharp created PR review comment:

Maybe I'm reading this wrong, but if ty.is_int() matches then the types::I128 case is unreachable, right? Seems like that case should be deleted too.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 23:30):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 23:30):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 23:42):

afonso360 created PR review comment:

That's true, I missed that. Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 23:42):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 23:44):

afonso360 updated PR #4506 from interp-icmp-imm-fix to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2022 at 23:50):

jameysharp has enabled auto merge for PR #4506.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2022 at 00:26):

jameysharp merged PR #4506.

Last updated: Dec 23 2024 at 12:05 UTC