Stream: git-wasmtime

Topic: wasmtime / PR #4502 fuzzgen: Fuzz Switch API

Wasmtime GitHub notifications bot (Jul 21 2022 at 19:54):

afonso360 edited PR #4502 from fuzzgen-switch to main:

Hey,

Turns out this is an interface that the frontend provides.
We should fuzz it.

cc: @jameysharp

Wasmtime GitHub notifications bot (Jul 21 2022 at 19:55):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2022 at 19:55):

bjorn3 created PR review comment:

For i128, maybe you could generate two variables and then use iconcat if get_variable_of_type doesn't support it directly?

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:02):

bjorn3 created PR review comment:

Switch is designed to work for any kind of pattern. It should work just as well for switches like 1..5, 7..12 as for those like 1, 7, 33, 91. The former will use a branch and then two jump tables, while the later will only use branches. I presume the current code is biased towards the later option, right?

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:02):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:03):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:03):

bjorn3 created PR review comment:

I think increasing this a bit will allow for more interesting patterns of generated code.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:03):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:03):

afonso360 created PR review comment:

I'm doing exactly that here!

But we need a few additional bits to introduce I128 support.

Right now the fuzzer is hitting #4498 and #4406 when I add I128 support. I can add support for I128 values and work around those two issues by disabling those ops for i128.

I think it would be best to do this in a separate PR.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:05):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:05):

bjorn3 created PR review comment:

You shouldn't hit https://github.com/bytecodealliance/wasmtime/issues/4498 for the Switch api, right? Only when using br_table directly.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:05):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:05):

afonso360 created PR review comment:

Yeah, Its going to be very unlikely that the fuzzer will generate that. I'll add a bias for adding contiguous ranges.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:41):

afonso360 updated PR #4502 from fuzzgen-switch to main.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:49):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:49):

afonso360 created PR review comment:

I don't think so, but we will hit the special cased lowering. I'll rebase the i128 patch after merging this, and disable the crashing ops so that we can start fuzzing Switch's i128.

Wasmtime GitHub notifications bot (Jul 21 2022 at 20:51):

afonso360 updated PR #4502 from fuzzgen-switch to main.

Wasmtime GitHub notifications bot (Jul 21 2022 at 21:29):

afonso360 updated PR #4502 from fuzzgen-switch to main.

Wasmtime GitHub notifications bot (Jul 23 2022 at 00:16):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jul 23 2022 at 08:58):

afonso360 updated PR #4502 from fuzzgen-switch to main.

Wasmtime GitHub notifications bot (Jul 23 2022 at 10:01):

afonso360 updated PR #4502 from fuzzgen-switch to main.

Wasmtime GitHub notifications bot (Jul 25 2022 at 22:26):

jameysharp merged PR #4502.

Last updated: Nov 22 2024 at 16:03 UTC