Wasmtime GitHub notifications bot (Jul 20 2022 at 19:51): Wasmtime GitHub notifications bot (Jul 20 2022 at 19:51):elliottt opened PR #4489 from trevor/add-inst-size-test-x64 to main:
Like the s390x backend, add a test that asserts the current size of x64 instructions to prevent them continuing to grow.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 20 2022 at 19:52):elliottt has marked PR #4489 as ready for review.
Wasmtime GitHub notifications bot (Jul 20 2022 at 21:44):alexcrichton created PR review comment:
Could this test have a
#[cfg(target_pointer_width = "64")]on it just in case we compile for a 32-bit platform one day?
Wasmtime GitHub notifications bot (Jul 20 2022 at 21:44):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jul 20 2022 at 21:44):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jul 20 2022 at 22:21):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Jul 20 2022 at 22:21):elliottt created PR review comment:
Great point, I'll add that!
Wasmtime GitHub notifications bot (Jul 20 2022 at 22:25):elliottt updated PR #4489 from trevor/add-inst-size-test-x64 to main.
Wasmtime GitHub notifications bot (Jul 20 2022 at 22:41):alexcrichton has enabled auto merge for PR #4489.
Wasmtime GitHub notifications bot (Jul 21 2022 at 00:01):alexcrichton merged PR #4489.
Last updated: Dec 23 2024 at 13:07 UTC