Stream: git-wasmtime

Topic: wasmtime / PR #4488 Components: ignore type exports (for ...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 19:30):

peterhuene opened PR #4488 from skip-type-exports to main:

This PR updates component translation to ignore type exports for now.

Components generated with wit-component contain type exports to give names to
types used within the component's functions based on the component's wit
definition.

The intention is to allow bindings to be generated with meaningful names
directly from a component. In the future, type exports (and imports) may be
used for more than this purpose to support things like resource types.

This PR effectively ignores type exports when translating the component as
they are not useful to executing a component at this time.

Closes #4415.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 19:30):

peterhuene requested alexcrichton for a review on PR #4488.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 21:43):

peterhuene updated PR #4488 from skip-type-exports to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 21:44):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 21:44):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 21:44):

alexcrichton created PR review comment:

I think this can also be added to something in tests/misc_testsuite/component-model if you'd prefer

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 21:46):

peterhuene created PR review comment:

I'll move it there, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 21:46):

peterhuene submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 22:23):

peterhuene submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 22:23):

peterhuene created PR review comment:

Are we running misc_testsuite with component-model feature flag in CI? A quick perusal of main.yml seems like we're only running the component_model test with cargo test --test all --features component-model component_model.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2022 at 22:38):

peterhuene updated PR #4488 from skip-type-exports to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2022 at 00:17):

peterhuene submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2022 at 00:17):

peterhuene created PR review comment:

Never mind, that does indeed run both sets as expected.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2022 at 00:50):

peterhuene merged PR #4488.

Last updated: Nov 22 2024 at 16:03 UTC