peterhuene opened PR #4488 from skip-type-exports
to main
:
This PR updates component translation to ignore type exports for now.
Components generated with
wit-component
contain type exports to give names to
types used within the component's functions based on the component's wit
definition.The intention is to allow bindings to be generated with meaningful names
directly from a component. In the future, type exports (and imports) may be
used for more than this purpose to support things like resource types.This PR effectively ignores type exports when translating the component as
they are not useful to executing a component at this time.Closes #4415.
peterhuene requested alexcrichton for a review on PR #4488.
peterhuene updated PR #4488 from skip-type-exports
to main
.
alexcrichton submitted PR review.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
I think this can also be added to something in
tests/misc_testsuite/component-model
if you'd prefer
peterhuene created PR review comment:
I'll move it there, thanks!
peterhuene submitted PR review.
peterhuene submitted PR review.
peterhuene created PR review comment:
Are we running
misc_testsuite
withcomponent-model
feature flag in CI? A quick perusal ofmain.yml
seems like we're only running thecomponent_model
test withcargo test --test all --features component-model component_model
.
peterhuene updated PR #4488 from skip-type-exports
to main
.
peterhuene submitted PR review.
peterhuene created PR review comment:
Never mind, that does indeed run both sets as expected.
peterhuene merged PR #4488.
Last updated: Dec 23 2024 at 12:05 UTC