Stream: git-wasmtime

Topic: wasmtime / PR #4485 x64: Port func_addr to ISLE

Wasmtime GitHub notifications bot (Jul 20 2022 at 18:12):

elliottt opened PR #4485 from trevor/funcaddr-isle to main:

• Remove the Box on name in LoadExtName
• Lower FuncAddr in ISLE
• Move opcodes that have been implemented in ISLE to the top
• Add an x64 compile test for func_addr

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 20 2022 at 18:14):

elliottt edited PR #4485 from trevor/funcaddr-isle to main:

Move the func_addr lowering for x64 into ISLE, and add a compile test for it. Additionally, change the name argument for LoadExtAddr from a Box<ExternalName> to ExternalName, as it greatly simplifies the interface with ISLE, and there didn't appear to be a downside.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 20 2022 at 18:22):

elliottt updated PR #4485 from trevor/funcaddr-isle to main.

Wasmtime GitHub notifications bot (Jul 20 2022 at 19:54):

elliottt updated PR #4485 from trevor/funcaddr-isle to main.

Wasmtime GitHub notifications bot (Jul 20 2022 at 20:37):

elliottt updated PR #4485 from trevor/funcaddr-isle to main.

Last updated: Dec 23 2024 at 13:07 UTC