Stream: git-wasmtime

Topic: wasmtime / PR #4485 x64: Port func_addr and symbol_value ...

Wasmtime GitHub notifications bot (Jul 20 2022 at 20:37):

elliottt edited PR #4485 from trevor/funcaddr-isle to main:

Move the func_addr lowering for x64 into ISLE, and add a compile test for it. Additionally, change the name argument for LoadExtAddr from a Box<ExternalName> to ExternalName, as it greatly simplifies the interface with ISLE, and there didn't appear to be a downside.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 20 2022 at 20:38):

elliottt has marked PR #4485 as ready for review.

Wasmtime GitHub notifications bot (Jul 20 2022 at 22:27):

elliottt updated PR #4485 from trevor/funcaddr-isle to main.

Wasmtime GitHub notifications bot (Jul 22 2022 at 07:50):

elliottt updated PR #4485 from trevor/funcaddr-isle to main.

Wasmtime GitHub notifications bot (Jul 22 2022 at 07:51):

elliottt requested cfallin for a review on PR #4485.

Wasmtime GitHub notifications bot (Jul 22 2022 at 21:46):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 22 2022 at 21:46):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 22 2022 at 21:46):

cfallin created PR review comment:

would it be worthwhile to have an auto-conversion for this?

Wasmtime GitHub notifications bot (Jul 22 2022 at 21:53):

elliottt created PR review comment:

Definitely! I'll add that in.

Wasmtime GitHub notifications bot (Jul 22 2022 at 21:53):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jul 22 2022 at 22:03):

elliottt updated PR #4485 from trevor/funcaddr-isle to main.

Wasmtime GitHub notifications bot (Jul 25 2022 at 18:11):

elliottt merged PR #4485.

Last updated: Dec 23 2024 at 13:07 UTC