Wasmtime GitHub notifications bot (Jul 20 2022 at 18:11): Wasmtime GitHub notifications bot (Jul 20 2022 at 18:11):bnjbvr opened PR #4484 from log-macros to main:
- First commit introduces a Cargo feature (disabled by default) to enable/disable trace logs in cranelift-codegen, as well as a macro that will call into
log::traceonly if the feature is enabled, following exactly what regalloc2 does. If downstream users set theirlog::max_leveltoTrace, they would pay the cost for the logging infrastructure, even if the logger eventually decides to throw away the logs' contents, so it's better overall to not call into the logging infra at all.- Second commit: previously disassembly was emitted if explicitly enabled (only in testing setups), or when the log level was debug or more. I suppose this was done during hacking on regalloc2 (as the commit introducing this change is the switch to regalloc2), and never reverted, so I've done that here. We could add a cranelift flag to be able to request that at runtime with the CLI, if needs be.
With this change and those from other PRs, there's no more meaningful difference between a Wasmtime embedding setting the log's max level to trace or above.
Wasmtime GitHub notifications bot (Jul 21 2022 at 08:13):bnjbvr updated PR #4484 from log-macros to main.
Wasmtime GitHub notifications bot (Jul 26 2022 at 14:57):bnjbvr requested cfallin for a review on PR #4484.
Wasmtime GitHub notifications bot (Jul 29 2022 at 22:57):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Aug 01 2022 at 08:17):bnjbvr updated PR #4484 from log-macros to main.
Wasmtime GitHub notifications bot (Aug 01 2022 at 09:19):bnjbvr merged PR #4484.
Last updated: Oct 23 2024 at 20:03 UTC